Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Update dependencies #65

Merged
merged 2 commits into from
Dec 30, 2018
Merged

Update dependencies #65

merged 2 commits into from
Dec 30, 2018

Conversation

ai
Copy link
Contributor

@ai ai commented Dec 28, 2018

@robwierzbowski thanks for your amazing work for this plugin.

I updated dependencies. The most important update is Browserslist. Old Browserslist is slow (@kgrz found performance impact from node-pixrem) and could throw an error on new queries (like very useful `not dead).

PostCSS and reduce-css-calc are less important but it will be good to update them.

What version should be used to release it:

  1. Browserslist 2.0 → 4.0 will not change public API for this plugin. So you do not need a major bump for it.
  2. PostCSS 6.0 → 7.0 does not require any plugin changes. PostCSS 7.0’s plugin will be still compatible with PostCSS 6.0. So you do not need a major bump for it.
  3. reduce-css-calc 1.0 → 2.0 changes. I didn’t find critical changes.

As result, I think minor changes will be OK (especially, because it will fix Browserslist error on new queries).

@ai
Copy link
Contributor Author

ai commented Dec 28, 2018

@robwierzbowski seems like we need a major release since PostCSS 7.0 does not support Node.js 4

@robwierzbowski
Copy link
Owner

Updates all look good to me. I'll merge and release a major.

@robwierzbowski robwierzbowski merged commit e72db33 into robwierzbowski:master Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants